I used to dive a lot, and trained up to Rescue Diver, but never completed the course as I got transferred for work.
I actually have here, in Houston, my BDC and my Suunto Computer. I probably used them one season.
The best place that I recommend doing diving is Egypt! Sharm El Sheikh is completely geared for diving. The Red Sea is extremely warm, no need for a full suit, and they have something called "Ras Mohamed" dive park where fishing is completely prohibited. This is like paradise under the sea! https://www.circledivers.com/diving-in-sharm-el-sheikh/dive-sites/ras-mohammed
You can get the entire family (Padi) certified easily, and they car really enjoy their time there, even if they don't come with you on the boat. You can snorkel and be surrounded by fishes.
There are some more technical dives. For example I did the Thistlegorm https://en.wikipedia.org/wiki/SS_Thistlegorm which can be challenging if you venture inside the holds. However, there are way too many tourists now. Even when I dove on it, there were plenty of tours around us, and we were kind of being too many in cramped spaces.
Close to Sharm el Sheikh, there is the Blue Hole in Dahab. It is a one day trip. There too, some serious dives. https://www.weseektravel.com/blue-hole-dahab/
Sharm used to be all US Dollars... so you did not need to care about local currency. But after the creation of the EURO, they changed to EUR, because it was 20% higher, and they kept the same rates. So 20USD became 20EUR.
Sharm used to be all Italian, then switched to all Russian tourists. I was the only non-Russian on my diving boat, and I had a few issues with my buddy.
The entire family would love Egypt.
However, because of the events that we know about, you will have to put Egypt on the back burner; I think.
I did a lot of diving in the Mediterranean Sea, France, Spain. Ionian Sea Sicily. Those would be more accessible in the current context. But not as much fun as Egypt....
As far as exotic destinations, I did Mauritius; again, not as much fun as Egypt for a family, and very expensive.
Unfortunately, I did not dive in the USA, because my days in a dry diving suit are over. Probably why I like the Red Sea so much. It is like diving in your bath tub. I have dived in Brittany, the estuary between UK and France, and this really a poor experience. You can't see anything, it is cold.
My last recommendation would be Puerto Madryn in Argentina. The USD is hard currency there. https://www.madrynbuceo.com/
You can fly any of the US major airline to Buenos Aires. If you choose Argentina, I can help you more as I still have an anchor in Buenos Aires myself.
Ideally, you would want to go there in December/January/February, during summer.